Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bend_direction ports #2577

Merged
merged 1 commit into from Mar 3, 2024
Merged

fix bend_direction ports #2577

merged 1 commit into from Mar 3, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Mar 3, 2024

fixes #2576

    c = bend_euler(direction='cw')
    c.show(show_ports=True)

before
image

after
image

@github-actions github-actions bot added the bug Something isn't working label Mar 3, 2024
@joamatab joamatab added the maintenance patch label Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.81%. Comparing base (e3a7689) to head (57ab09a).

Files Patch % Lines
gdsfactory/components/bend_euler.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2577   +/-   ##
=======================================
  Coverage   71.81%   71.81%           
=======================================
  Files         368      368           
  Lines       23911    23911           
  Branches     3948     3948           
=======================================
  Hits        17171    17171           
  Misses       5529     5529           
  Partials     1211     1211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 9a5c25c into main Mar 3, 2024
11 of 13 checks passed
@joamatab joamatab deleted the fix_bend_direction_ports branch March 3, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bend port issue
1 participant