Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update args for from_image to match from_np #2595

Merged
merged 1 commit into from Mar 6, 2024

Conversation

thomasdorch
Copy link
Contributor

Fix for #2582: Updating args for the from_image function to match from_np.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (490d951) to head (e3a913c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2595   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files         367      367           
  Lines       23865    23865           
  Branches     3949     3949           
=======================================
  Hits        17042    17042           
  Misses       5616     5616           
  Partials     1207     1207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 1728a80 into gdsfactory:main Mar 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants