Small improvements #2641
Merged
Small improvements #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @joamatab - I've reviewed your changes and they look great!
General suggestions:
- Verify the consistency of data types for component dimensions across all modifications.
- Consider the impact of removing float conversion on the system's type consistency.
- Review the necessity of commented-out code and remove if it's no longer relevant.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -107,9 +104,10 @@ def taper( | |||
| port_type=port_order_types[1], | |||
| ) | |||
|
|
|||
| c.info["length"] = float(length) | |||
| c.info["length"] = length | |||
There was a problem hiding this comment.
issue (bug_risk): Ensure type consistency for 'length' in 'c.info'.
The removal of float conversion might introduce type inconsistency if 'length' is not guaranteed to be a float elsewhere.
| @@ -82,7 +82,7 @@ def grating_coupler_elliptical_trenches( | |||
| c = gf.Component() | |||
|
|
|||
| # Make each grating line | |||
| for p in range(p_start, p_start + n_periods + 1): | |||
| for p in range(int(p_start), int(p_start + n_periods + 1)): | |||
There was a problem hiding this comment.
suggestion (code-quality): Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)
Suggested change
| for p in range(int(p_start), int(p_start + n_periods + 1)): | |
| for p in range(p_start, int(p_start + n_periods + 1)): |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
=======================================
Coverage 71.77% 71.78%
=======================================
Files 366 366
Lines 23736 23732 -4
Branches 3874 3873 -1
=======================================
- Hits 17037 17035 -2
+ Misses 5574 5572 -2
Partials 1125 1125 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LuYouxi