Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom import gds #2661

Merged
merged 4 commits into from
Apr 10, 2024
Merged

allow custom import gds #2661

merged 4 commits into from
Apr 10, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Apr 9, 2024

fixes #1547

it requires custom import_gds to be like this

@gf.cell(autoname=False, copy_if_cached=False)
def import_gds_custom(gdspath, **kwargs):
    return gf.import_gds(gdspath, **kwargs)

@tvt173
@friederike-joehlinger-wavephotonics
@FJohlinger

@joamatab joamatab added the maintenance patch label Apr 9, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joamatab - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

tests/test_import_gds.py Show resolved Hide resolved
tests/test_import_gds.py Show resolved Hide resolved
tests/test_import_gds.py Show resolved Hide resolved
@joamatab joamatab requested a review from tvt173 April 9, 2024 18:42
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (ffdff4f) to head (39251b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
- Coverage   71.77%   71.77%   -0.01%     
==========================================
  Files         366      366              
  Lines       23756    23757       +1     
  Branches     3874     3874              
==========================================
  Hits        17052    17052              
- Misses       5578     5580       +2     
+ Partials     1126     1125       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 07f9780 into main Apr 10, 2024
12 of 13 checks passed
@joamatab joamatab deleted the allow_custom_import_gds branch April 10, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant