Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caught an untested bug on the straight component:
c.info["length"] = length
. Pydantic complained that length was not int or float (and it did not coerce it). Instead it was a numpy int which was returned by a rounding function. I fixed withc.info["length"] = float(length)
.I assumed this was the right solution as I saw it somewhere else in the codebase. Hope others find this error here. I am pasting the error in case someone might google: