Pdk improvements

gdsfactory/components/ring_crow.py

@@ -12,24 +12,28 @@
 def ring_crow(
     gaps: list[float] = [0.2] * 4,
     radius: list[float] = [10.0] * 3,
-    input_straight_cross_section: CrossSectionSpec = strip,
-    output_straight_cross_section: CrossSectionSpec = strip,
     bends: list[ComponentSpec] = [bend_circular] * 3,
     ring_cross_sections: list[CrossSectionSpec] = [strip] * 3,
     length_x: float = 0,
     lengths_y: list[float] = [0] * 3,
+    input_straight_cross_section: CrossSectionSpec | None = None,
+    output_straight_cross_section: CrossSectionSpec | None = None,
+    cross_section: CrossSectionSpec = "xs_sc",
 ) -> Component:
     """Coupled ring resonators.
 
     Args:
-        gap: gap between for coupler.
-        radius: for the bend and coupler.
+        gaps: gap between rings.
+        radius: for each ring.
+        bends: bend spec for each ring.
+        ring_cross_sections: cross_section spec for each ring.
         length_x: ring coupler length.
         length_y: vertical straight length.
         coupler: ring coupler spec.
         straight: straight spec.
-        bend: bend spec.
-        cross_section: cross_section spec.
+        input_straight_cross_section: cross_section spec for input and output straight. Defaults to cross_section.
+        output_straight_cross_section: cross_section spec for input and output straight. Defaults to cross_section.
+        cross_section: cross_section spec for input and output straight.
         kwargs: cross_section settings.
 
     .. code::
@@ -59,6 +63,11 @@ def ring_crow(
           length_x
     """
     c = Component()
+    input_straight_cross_section = input_straight_cross_section or cross_section
+    output_straight_cross_section = output_straight_cross_section or cross_section
+
+    output_straight_cross_section = gf.get_cross_section(output_straight_cross_section)
+    input_straight_cross_section = gf.get_cross_section(input_straight_cross_section)
 
     # Input bus
     input_straight = gf.get_component(
@@ -128,7 +137,7 @@ def ring_crow(
         length=2 * radius[-1] + length_x,
         cross_section=output_straight_cross_section,
     )
-    output_straight_width = output_straight_cross_section().width
+    output_straight_width = output_straight_cross_section.width
     output_straight_waveguide = (
         c.add_ref(output_straight)
         .movey(cum_y_dist + gaps[-1] + output_straight_width / 2)

gdsfactory/components/spiral_double.py

@@ -7,7 +7,7 @@
 
 @gf.cell
 def spiral_double(
-    min_bend_radius: float = 10.0,
+    min_bend_radius: float | None = None,
     separation: float = 2.0,
     number_of_loops: float = 3,
     npoints: int = 1000,
@@ -17,14 +17,16 @@ def spiral_double(
     """Returns a spiral double (spiral in, and then out).
 
     Args:
-        min_bend_radius: inner radius of the spiral.
+        min_bend_radius: inner radius of the spiral. Defaults to cross_section radius.
         separation: separation between the loops.
         number_of_loops: number of loops per spiral.
         npoints: points for the spiral.
         cross_section: cross-section to extrude the structure with.
         bend: factory for the bends in the middle of the double spiral.
     """
     component = gf.Component()
+    xs = gf.get_cross_section(cross_section)
+    min_bend_radius = min_bend_radius or xs.radius
 
     bend = gf.get_component(
         bend, radius=min_bend_radius / 2, angle=180, cross_section=cross_section

gdsfactory/generic_tech/simulation_settings.py

@@ -1,15 +1,11 @@
 from __future__ import annotations
 
 from functools import partial
-from typing import TYPE_CHECKING
 
 import numpy as np
 from pydantic import BaseModel
 from scipy import interpolate
 
-if TYPE_CHECKING:
-    pass
-
 material_name_to_lumerical_default = {
     "si": "Si (Silicon) - Palik",
     "sio2": "SiO2 (Glass) - Palik",

test-data-regression/test_settings_ring_crow_.yml

@@ -7,28 +7,19 @@ settings:
   - function: bend_circular
   - function: bend_circular
   - function: bend_circular
+  cross_section: xs_sc
   gaps:
   - 0.2
   - 0.2
   - 0.2
   - 0.2
-  input_straight_cross_section:
-    function: cross_section
-    module: gdsfactory.cross_section
-    settings:
-      radius: 10
-      radius_min: 5
+  input_straight_cross_section: null
   length_x: 0
   lengths_y:
   - 0
   - 0
   - 0
-  output_straight_cross_section:
-    function: cross_section
-    module: gdsfactory.cross_section
-    settings:
-      radius: 10
-      radius_min: 5
+  output_straight_cross_section: null
   radius:
   - 10.0
   - 10.0

test-data-regression/test_settings_spiral_double_.yml

@@ -7,7 +7,7 @@ settings:
   bend:
     function: bend_circular
   cross_section: xs_sc
-  min_bend_radius: 10.0
+  min_bend_radius: null
   npoints: 1000
   number_of_loops: 3
   separation: 2.0