New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid width missmatch #2701
Forbid width missmatch #2701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joamatab - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
"e3", | ||
bottom_heater_ref.ports["o1"], | ||
allow_layer_mismatch=True, | ||
allow_type_mismatch=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Assess the impact of type mismatch allowances on system performance.
Allowing type mismatches can sometimes lead to performance degradation or unexpected behavior. It's crucial to evaluate whether the benefits outweigh the potential risks in this context.
allow_type_mismatch=True, | |
allow_type_mismatch=False, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
==========================================
- Coverage 71.73% 71.71% -0.02%
==========================================
Files 366 366
Lines 23784 23795 +11
Branches 3876 3876
==========================================
+ Hits 17061 17065 +4
- Misses 5593 5603 +10
+ Partials 1130 1127 -3 ☔ View full report in Codecov by Sentry. |
in some cases this may be nice, in some cases this may be undesirable. i.e. you want to see in the GDS where the error is happening. is there a way to globally disable this if necessary? |
yes, you can define a https://gdsfactory.github.io/gdsfactory/notebooks/12_config.html |
@nikosavola
@sebastian-goeldi
@tvt173