Improve layer stack #2726
Merged
Improve layer stack #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @joamatab - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -65,7 +69,7 @@ def to_3d( | |||
| # print(layer, height, zmin, opacity, layer_view.visible) | |||
|
|
|||
| if zmin is not None and layer_view.visible: | |||
| for polygon in polygons: | |||
| for polygon in layer_to_polygon[layer]: | |||
There was a problem hiding this comment.
issue (edge_case_not_handled): Check if 'layer_to_polygon' dictionary always contains all layers as keys to avoid KeyError.
| @@ -94,6 +96,21 @@ def model_copy(self) -> LayerStack: | |||
| """Returns a copy of the LayerStack.""" | |||
| return LayerStack.model_validate_json(self.model_dump_json()) | |||
|
|
|||
| def pprint(self) -> None: | |||
There was a problem hiding this comment.
suggestion (code_refinement): Consider renaming 'pprint' to a more descriptive method name indicating its specific functionality.
Suggested change
| def pprint(self) -> None: | |
| def print_layer_stack_table(self) -> None: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
==========================================
- Coverage 71.64% 71.60% -0.05%
==========================================
Files 367 367
Lines 23857 23875 +18
Branches 3889 3893 +4
==========================================
+ Hits 17092 17095 +3
- Misses 5638 5656 +18
+ Partials 1127 1124 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@doddgray