Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gf.path.extrude() Inset Fix #2729

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

fp-matt
Copy link
Contributor

@fp-matt fp-matt commented May 9, 2024

Proposed fixes for issue #2724

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fp-matt - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 71.56%. Comparing base (141cd3d) to head (0d8df62).

Files Patch % Lines
gdsfactory/path.py 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
- Coverage   71.60%   71.56%   -0.05%     
==========================================
  Files         367      367              
  Lines       23875    23889      +14     
  Branches     3893     3893              
==========================================
  Hits        17095    17095              
- Misses       5656     5670      +14     
  Partials     1124     1124              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab added the bug Something isn't working label May 9, 2024
@joamatab joamatab self-requested a review May 9, 2024 05:49
Copy link
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thank you Matthew!

@joamatab joamatab merged commit 536de6d into gdsfactory:main May 9, 2024
11 of 14 checks passed
@fp-matt fp-matt deleted the path_extrude_inset_fix branch May 30, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants