Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get route astar #2752

Merged
merged 4 commits into from
May 16, 2024
Merged

Improve get route astar #2752

merged 4 commits into from
May 16, 2024

Conversation

joamatab
Copy link
Contributor

improve astar router thanks to @juanferv

#57 (comment)

original astar code was made by @SkandanC

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab added enhancement New feature or request routing labels May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 71.74%. Comparing base (0e1b0cf) to head (573f593).

Files Patch % Lines
gdsfactory/routing/get_route_astar.py 20.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
+ Coverage   71.64%   71.74%   +0.09%     
==========================================
  Files         369      369              
  Lines       23892    23858      -34     
  Branches     3889     3882       -7     
==========================================
- Hits        17118    17116       -2     
+ Misses       5652     5620      -32     
  Partials     1122     1122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@juanferv juanferv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool fixing! now it is working even with optical layers. It works in a lot of dificcult scenarios. We want to test it in difficult scenario of a routing

@joamatab joamatab merged commit c99ab05 into main May 16, 2024
18 of 20 checks passed
@joamatab joamatab deleted the improve_get_route_astar branch May 16, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants