Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to kfactory backend #2766

Merged
merged 7 commits into from
May 20, 2024
Merged

update to kfactory backend #2766

merged 7 commits into from
May 20, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented May 20, 2024

  • work towards kfactory backend

@sebastian-goeldi

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #2766 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 566.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 20, 2024
@joamatab joamatab merged commit 7f1cda3 into main May 20, 2024
6 of 14 checks passed
@joamatab joamatab deleted the gdsfactory8 branch May 20, 2024 06:00
@govenius
Copy link

I wonder if the potential licensing conflict that may arise from bringing in a tight dependence to GPL-licensed code (KLayout) was analyzed and taken into account here. The author of KLayout interprets there not to be an issue with Python import statements, but it's not really his call since KLayout itself is forced to use GPL due to its dependencies. So it doesn't seem like a negligible risk, or at least it's a significant potential complication, and therefore worth putting some serious thought into before creating a hard-to-reverse dependence on GPL-licensed code. If this is already fully understood and the risk has been accepted, then no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants