New sort ports #2788
Merged
New sort ports #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
|
|
||
|
|
||
| def test_route_bundle_obstacle( | ||
| data_regression: DataRegressionFixture, check: bool = True |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Convert for loop into dictionary comprehension (
dict-comprehension) - Move assignments closer to their usage (
move-assign)
sebastian-goeldi
approved these changes
May 26, 2024
| @@ -736,14 +736,14 @@ def plot_netlist( | |||
| ) | |||
| return G | |||
|
|
|||
| def over_under(self, layer: LayerSpec, distance: float = 1.0) -> None: | |||
| def over_under(self, layer: LayerSpec, distance: int = 1) -> None: | |||
| """Flattens and performs over-under on a layer in the Component. | |||
There was a problem hiding this comment.
Do you really need to flatten? I think this makes it strictly bigger, so theoretically it shouldn't be necessary to flatten. But maybe a flag? Otherwise, sure flattening works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use sort ports from kfactory