Remove warnings #2796
Merged
Remove warnings #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joamatab
commented
May 28, 2024
joamatab
commented
- rename xmin to dxmin, ....
- rename mirror to dmirror
github-actions
bot
added
the
documentation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Comment on lines
+52
to
+55
| p1.dmirror = not p1.dmirror | ||
| else: | ||
| p1 = b_inners[0].ports["o1"] | ||
| p1.mirror = not p1.mirror | ||
| p1.dmirror = not p1.dmirror |
There was a problem hiding this comment.
issue (code-quality): Hoist repeated code outside conditional statement (hoist-statement-from-if)
|
it never struck me that even |
tvt173
approved these changes
May 28, 2024
|
Mirror only has a difference if you set a mirror plane, otherwise it is identical |
sebastian-goeldi
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.