Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix less than 1nm issue #2811

Merged
merged 2 commits into from
Jun 1, 2024
Merged

fix less than 1nm issue #2811

merged 2 commits into from
Jun 1, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jun 1, 2024

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Jun 1, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 68.25%. Comparing base (fae9f6c) to head (8e3d320).
Report is 2 commits behind head on main.

Files Patch % Lines
gdsfactory/add_ports.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2811   +/-   ##
=======================================
  Coverage   68.25%   68.25%           
=======================================
  Files         300      300           
  Lines       15594    15595    +1     
  Branches     2276     2276           
=======================================
+ Hits        10643    10644    +1     
  Misses       4357     4357           
  Partials      594      594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 19f3229 into main Jun 1, 2024
10 of 15 checks passed
@joamatab joamatab deleted the fix_ports_with_less_1nm_grid branch June 1, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant