Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings2 #2816

Merged
merged 15 commits into from
Jun 2, 2024
Merged

Remove warnings2 #2816

merged 15 commits into from
Jun 2, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jun 2, 2024

  • add gf.c.text_klayout
  • remove cell decorator
  • flatten taper
  • flatten grating_coupler_rectangular
  • run clean_value_json for netlists and Component.to_dict()

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab added the bug Something isn't working label Jun 2, 2024
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 68.33%. Comparing base (9812c5a) to head (223cc4b).
Report is 6 commits behind head on main.

Files Patch % Lines
gdsfactory/components/text.py 76.92% 2 Missing and 1 partial ⚠️
gdsfactory/pdk.py 50.00% 3 Missing ⚠️
gdsfactory/component.py 71.42% 2 Missing ⚠️
gdsfactory/cross_section.py 50.00% 1 Missing ⚠️
gdsfactory/difftest.py 50.00% 1 Missing ⚠️
gdsfactory/get_factories.py 50.00% 1 Missing ⚠️
gdsfactory/path.py 50.00% 1 Missing ⚠️
gdsfactory/read/from_gdspaths.py 50.00% 1 Missing ⚠️
gdsfactory/symbols.py 0.00% 1 Missing ⚠️
gdsfactory/write_cells.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2816      +/-   ##
==========================================
+ Coverage   68.24%   68.33%   +0.09%     
==========================================
  Files         300      300              
  Lines       15596    15592       -4     
  Branches     2277     2276       -1     
==========================================
+ Hits        10643    10655      +12     
+ Misses       4357     4342      -15     
+ Partials      596      595       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit d572adf into main Jun 2, 2024
11 of 15 checks passed
@joamatab joamatab deleted the remove_warnings2 branch June 2, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant