Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #2817

Merged
merged 14 commits into from
Jun 3, 2024
Merged

minor fixes #2817

merged 14 commits into from
Jun 3, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jun 3, 2024

  • some parts were not fully refactored

@github-actions github-actions bot added the bug Something isn't working label Jun 3, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

gdsfactory/component_layout.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 79.74684% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 68.58%. Comparing base (d572adf) to head (a29657a).

Files Patch % Lines
gdsfactory/components/straight_heater_meander.py 33.33% 3 Missing and 1 partial ⚠️
gdsfactory/components/spiral_heater.py 76.92% 2 Missing and 1 partial ⚠️
gdsfactory/components/component_sequence.py 0.00% 2 Missing ⚠️
gdsfactory/read/from_yaml.py 50.00% 2 Missing ⚠️
gdsfactory/write_cells.py 0.00% 2 Missing ⚠️
gdsfactory/add_ports.py 0.00% 1 Missing ⚠️
gdsfactory/component_layout.py 66.66% 1 Missing ⚠️
gdsfactory/routing/add_electrical_pads_top_dc.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
+ Coverage   68.32%   68.58%   +0.26%     
==========================================
  Files         300      300              
  Lines       15592    15584       -8     
  Branches     2276     2280       +4     
==========================================
+ Hits        10653    10689      +36     
+ Misses       4343     4297      -46     
- Partials      596      598       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 368feae into main Jun 3, 2024
12 of 16 checks passed
@joamatab joamatab deleted the update_kfactory branch June 3, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants