Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs #2836

Merged
merged 6 commits into from
Jun 8, 2024
Merged

improve docs #2836

merged 6 commits into from
Jun 8, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jun 8, 2024

fixes #2834

thank you @sebastian-goeldi

Copy link
Contributor

sourcery-ai bot commented Jun 8, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 68.96%. Comparing base (34ccc99) to head (400a7a1).
Report is 1 commits behind head on main.

Files Patch % Lines
gdsfactory/samples/12_component_refs.py 16.66% 10 Missing ⚠️
gdsfactory/component.py 0.00% 1 Missing ⚠️
gdsfactory/samples/05_remove_layers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2836      +/-   ##
==========================================
- Coverage   68.98%   68.96%   -0.02%     
==========================================
  Files         299      298       -1     
  Lines       15345    15348       +3     
  Branches     2244     2244              
==========================================
  Hits        10585    10585              
- Misses       4158     4161       +3     
  Partials      602      602              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab added the documentation Improvements or additions to documentation label Jun 8, 2024
@joamatab joamatab merged commit 4034a00 into main Jun 8, 2024
10 of 14 checks passed
@joamatab joamatab deleted the improve_docs branch June 8, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document issue
1 participant