Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add klayout_tech to pdk #2854

Merged
merged 2 commits into from
Jun 11, 2024
Merged

add klayout_tech to pdk #2854

merged 2 commits into from
Jun 11, 2024

Conversation

joamatab
Copy link
Contributor

No description provided.

Copy link
Contributor

sourcery-ai bot commented Jun 11, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@github-actions github-actions bot added the enhancement New feature or request label Jun 11, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.89%. Comparing base (d901933) to head (52ca081).

Files Patch % Lines
gdsfactory/pdk.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2854      +/-   ##
==========================================
- Coverage   68.90%   68.89%   -0.02%     
==========================================
  Files         298      298              
  Lines       15359    15365       +6     
  Branches     2253     2254       +1     
==========================================
+ Hits        10583    10585       +2     
- Misses       4178     4182       +4     
  Partials      598      598              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 754ae8f into main Jun 11, 2024
9 of 15 checks passed
@joamatab joamatab deleted the klayout_tech branch June 11, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant