Fix for boolean example in Geometry notebook #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to grab polygons from appropriate layers of input components
Removed code that moved the rectangle in the example down by 1.5um to more directly show the before and after of the boolean subtraction
|
🧙 Sourcery is reviewing your pull request! Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2860 +/- ##
=======================================
Coverage 68.83% 68.83%
=======================================
Files 298 298
Lines 15369 15369
Branches 2256 2256
=======================================
Hits 10580 10580
Misses 4190 4190
Partials 599 599 ☔ View full report in Codecov by Sentry. |
joamatab
approved these changes
Jun 13, 2024
|
Thank you Matthew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
gf.boolean(...)outputting empty component in geometry docs notebookalso removed code moving the rectangle down by 1.5um to make the image rendered in the docs a clearer before and after comparison