add archimedean spiral

[HelgeGehring]

added spiral to path.py

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.27%.

Quality metrics	Before	After	Change
Complexity	36.42 ⛔	36.16 ⛔	-0.26 👍
Method Length	81.25 🙂	80.03 🙂	-1.22 👍
Working memory	14.73 😞	14.69 😞	-0.04 👍
Quality	39.52% 😞	39.79% 😞	0.27% 👍

Other metrics	Before	After	Change
Lines	765	787	22

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/path.py	39.52% 😞	39.79% 😞	0.27% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/path.py	extrude	89 ⛔	833 ⛔	23 ⛔	2.95% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/path.py	transition	27 😞	296 ⛔	17 ⛔	21.04% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/path.py	_cut_path_with_ray	14 🙂	299 ⛔	14 😞	33.40% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/path.py	_demo	0 ⭐	217 ⛔	11 😞	55.31% 🙂	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/path.py	euler	0 ⭐	32 ⭐	10 😞	79.42% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov]

Codecov Report

Merging #492 (4f8f0fb) into master (773e64c) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files         395      395           
  Lines       17352    17354    +2     
  Branches     2404     2405    +1     
=======================================
+ Hits        13122    13124    +2     
- Misses       3533     3534    +1     
+ Partials      697      696    -1     

Impacted Files	Coverage Δ
gdsfactory/path.py	69.70% <50.00%> (-0.13%)	⬇️
gdsfactory/read/from_yaml.py	66.56% <0.00%> (+0.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773e64c...4f8f0fb. Read the comment docs.

[joamatab]

Thank you Helge

• You need to follow Google Python Style Guide. You can take a look at the other Pcell docstrings.
• You should make sure tests pass
• You should install pre-commit to get the pre-commit checks passing (autoformat the code, run linter ...)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[joamatab]

awesome! thank you Helge!