Realize #496

[jan-david-fischbach]

Extracted generating doe list suggested in #496

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 6.93%.

Quality metrics	Before	After	Change
Complexity	7.24 ⭐	5.40 ⭐	-1.84 👍
Method Length	84.75 🙂	72.80 🙂	-11.95 👍
Working memory	10.43 😞	9.68 🙂	-0.75 👍
Quality	58.02% 🙂	64.95% 🙂	6.93% 👍

Other metrics	Before	After	Change
Lines	142	161	19

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/components/pack_doe.py	58.02% 🙂	64.95% 🙂	6.93% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/components/pack_doe.py	pack_doe_grid	8 ⭐	128 😞	11 😞	55.66% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
28.6% Duplication

[codecov]

Codecov Report

Merging #497 (dc22d75) into master (47b7f31) will decrease coverage by 0.00%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
- Coverage   75.62%   75.62%   -0.01%     
==========================================
  Files         395      395              
  Lines       17352    17360       +8     
  Branches     2404     2406       +2     
==========================================
+ Hits        13123    13128       +5     
- Misses       3533     3536       +3     
  Partials      696      696              

Impacted Files	Coverage Δ
gdsfactory/components/pack_doe.py	73.33% <69.23%> (+1.90%)	⬆️
gdsfactory/tech.py	92.06% <0.00%> (-1.44%)	⬇️
gdsfactory/path.py	69.70% <0.00%> (-0.13%)	⬇️
gdsfactory/pdk.py	51.55% <0.00%> (ø)
gdsfactory/__init__.py	100.00% <0.00%> (ø)
gdsfactory/pixelate.py	20.23% <0.00%> (ø)
gdsfactory/components/coupler_adiabatic.py	87.50% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b7f31...dc22d75. Read the comment docs.

[joamatab]

awesome! thank you Jan-David!