Simphony monte carlo fix

[SkandanC]

Fix for incorrect Monte Carlo computations for the MZI circuit. Issue is with SiPANN Waveguide component. Replaced it with SiEPIC Waveguide component.

[sourcery-ai]

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics	Before	After	Change
Complexity	2.81 ⭐	2.81 ⭐	0.00
Method Length	38.33 ⭐	38.33 ⭐	0.00
Working memory	10.77 😞	10.77 😞	0.00
Quality	69.09% 🙂	69.09% 🙂	0.00%

Other metrics	Before	After	Change
Lines	88	89	1

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/simulation/simphony/plot_circuit_montecarlo.py	59.97% 🙂	59.97% 🙂	0.00%
gdsfactory/simulation/simphony/components/straight.py	83.54% ⭐	83.54% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/simulation/simphony/plot_circuit_montecarlo.py	plot_circuit_montecarlo	5 ⭐	126 😞	15 😞	52.81% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Merging #530 (f153c6b) into master (1e27e35) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   75.54%   75.50%   -0.05%     
==========================================
  Files         397      401       +4     
  Lines       17376    17402      +26     
  Branches     2407     2411       +4     
==========================================
+ Hits        13127    13139      +12     
- Misses       3553     3565      +12     
- Partials      696      698       +2     

Impacted Files	Coverage Δ
gdsfactory/add_pins.py	57.07% <0.00%> (-0.29%)	⬇️
gdsfactory/samples/30_lidar_pcell.py	15.78% <0.00%> (ø)
gdsfactory/samples/30_lidar_with_pads.py	100.00% <0.00%> (ø)
gdsfactory/samples/30_lidar.py	100.00% <0.00%> (ø)
gdsfactory/samples/22_add_pads.py	100.00% <0.00%> (ø)
gdsfactory/components/extension.py	66.03% <0.00%> (+0.65%)	⬆️
gdsfactory/component_reference.py	67.22% <0.00%> (+1.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e27e35...f153c6b. Read the comment docs.

[joamatab]

Thank you Skandan!