Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load matplotlib #539

Merged
merged 7 commits into from Jul 13, 2022
Merged

Lazy load matplotlib #539

merged 7 commits into from Jul 13, 2022

Conversation

joamatab
Copy link
Contributor

  • lazy load matplotlib
  • make port.orientation None marker to be a cross.
  • add settings label can ignore settings
  • better message for symlinks in gf tool install
  • fix write_cells code. Add a test.
  • better mutability error message fix issue
  • add YouTube Video link to docs

@joamatab joamatab merged commit 508a644 into master Jul 13, 2022
@joamatab joamatab deleted the lazy_load_matplotlib branch July 13, 2022 10:18
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 13, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.26%.

Quality metrics Before After Change
Complexity 7.89 ⭐ 7.76 ⭐ -0.13 👍
Method Length 67.71 🙂 68.55 🙂 0.84 👎
Working memory 10.42 😞 10.52 😞 0.10 👎
Quality 62.95% 🙂 62.69% 🙂 -0.26% 👎
Other metrics Before After Change
Lines 3646 3722 76
Changed files Quality Before Quality After Quality Change
gdsfactory/component.py 70.42% 🙂 70.36% 🙂 -0.06% 👎
gdsfactory/layers.py 68.18% 🙂 68.20% 🙂 0.02% 👍
gdsfactory/quickplotter.py 58.91% 🙂 59.08% 🙂 0.17% 👍
gdsfactory/tech.py 73.19% 🙂 70.20% 🙂 -2.99% 👎
gdsfactory/write_cells.py 71.43% 🙂 66.86% 🙂 -4.57% 👎
gdsfactory/components/straight_heater_doped_rib.py 21.92% ⛔ 21.92% ⛔ 0.00%
gdsfactory/components/straight_heater_meander.py 34.03% 😞 34.03% 😞 0.00%
gdsfactory/geometry/write_drc.py 71.69% 🙂 71.05% 🙂 -0.64% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/quickplotter.py quickplot 57 ⛔ 533 ⛔ 21 ⛔ 6.01% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/straight_heater_doped_rib.py straight_heater_doped_rib 27 😞 421 ⛔ 33 ⛔ 12.63% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/quickplotter.py quickplot2 40 ⛔ 242 ⛔ 11 😞 26.01% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/straight_heater_meander.py straight_heater_meander 7 ⭐ 505 ⛔ 28 ⛔ 28.10% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.add_port 15 🙂 212 ⛔ 23 ⛔ 29.69% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant