Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy parallelism with new naming conventions #649

Merged
merged 3 commits into from Aug 31, 2022

Conversation

simbilod
Copy link
Collaborator

see #644

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 31, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.51%.

Quality metrics Before After Change
Complexity 21.83 😞 21.53 😞 -0.30 👍
Method Length 162.00 😞 161.93 😞 -0.07 👍
Working memory 3.38 ⭐ 3.44 ⭐ 0.06 👎
Quality 41.64% 😞 43.15% 😞 1.51% 👍
Other metrics Before After Change
Lines 598 630 32
Changed files Quality Before Quality After Quality Change
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py 77.79% ⭐ 77.21% ⭐ -0.58% 👎
gdsfactory/simulation/gmeep/write_sparameters_meep.py 26.51% 😞 25.60% 😞 -0.91% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/simulation/gmeep/write_sparameters_meep.py write_sparameters_meep 47 ⛔ 910 ⛔ 5.64% ⛔ Refactor to reduce nesting. Try splitting into smaller methods
gdsfactory/simulation/gmeep/write_sparameters_meep.py parse_port_eigenmode_coeff 6 ⭐ 177 😞 13 😞 49.16% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py test_sparameters_straight_batch 1 ⭐ 195 😞 6 ⭐ 66.88% 🙂 Try splitting into smaller methods
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py test_sparameterslazy_parallelism 0 ⭐ 146 😞 5 ⭐ 74.99% 🙂 Try splitting into smaller methods
gdsfactory/simulation/gmeep/test_write_sparameters_meep.py test_sparameters_straight_symmetric 0 ⭐ 151 😞 4 ⭐ 77.09% ⭐ Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit 0e12687 into gdsfactory:master Aug 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@simbilod simbilod deleted the lazy_parallelism_new_portNames branch November 12, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants