Klayout Technology (finished?)

[thomasdorch]

Now we can:

• Read/write layer files (.lyp) and specify whether the layer number is displayed in KLayout (KLayout Technology #695)
• Read/write technology files (.lyt)
  • Requires the klayout.db module
  • 2.5D layer stacks can only be written due to incomplete API in 0.27.x (#1153)

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 4.58%.

Quality metrics	Before	After	Change
Complexity	5.94 ⭐	6.99 ⭐	1.05 👎
Method Length	65.78 🙂	72.93 🙂	7.15 👎
Working memory	8.04 🙂	9.01 🙂	0.97 👎
Quality	69.24% 🙂	64.66% 🙂	-4.58% 👎

Other metrics	Before	After	Change
Lines	516	559	43

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/klayout_tech.py	69.24% 🙂	64.66% 🙂	-4.58% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/klayout_tech.py	KLayoutTechnology.export_technology_files	9 🙂	215 ⛔	15 😞	40.67% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/klayout_tech.py	LayerView._get_xml_element	14 🙂	141 😞	13 😞	45.47% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/klayout_tech.py	LayerDisplayProperties.add_layer	3 ⭐	143 😞	24 ⛔	46.52% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/klayout_tech.py	LayerDisplayProperties.from_lyp	11 🙂	220 ⛔	9 🙂	48.45% 😞	Try splitting into smaller methods
gdsfactory/klayout_tech.py	_properties_to_layerview	13 🙂	129 😞	11 😞	51.01% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

No Coverage information
1.1% Duplication

[joamatab]

Looks great!

thank you Thomas!