Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal solver #739

Merged
merged 4 commits into from Sep 29, 2022
Merged

Thermal solver #739

merged 4 commits into from Sep 29, 2022

Conversation

HelgeGehring
Copy link
Collaborator

First version of a FEM thermal simulation

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #739 (b0433c0) into master (323a9fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #739   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files         407      407           
  Lines       19179    19179           
  Branches     2697     2697           
=======================================
  Hits        14491    14491           
  Misses       3874     3874           
  Partials      814      814           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit b0433c0 into gdsfactory:master Sep 29, 2022
@joamatab
Copy link
Contributor

looks great Helge!

We may want to add a notebook example on the docs

@joamatab
Copy link
Contributor

I also get ValueError: Subdomain '(47, 0)' not found. when running simulation/heater.py

@joamatab joamatab mentioned this pull request Sep 29, 2022
@simbilod simbilod mentioned this pull request Sep 30, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants