Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove changelog and version #752

Merged
merged 2 commits into from Oct 2, 2022
Merged

remove changelog and version #752

merged 2 commits into from Oct 2, 2022

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Oct 2, 2022

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 2, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.19%.

Quality metrics Before After Change
Complexity 5.81 ⭐ 5.82 ⭐ 0.01 👎
Method Length 67.88 🙂 67.64 🙂 -0.24 👍
Working memory 8.60 🙂 8.52 🙂 -0.08 👍
Quality 66.57% 🙂 66.76% 🙂 0.19% 👍
Other metrics Before After Change
Lines 2120 2096 -24
Changed files Quality Before Quality After Quality Change
gdsfactory/component.py 66.73% 🙂 66.85% 🙂 0.12% 👍
gdsfactory/simulation/gmsh/scratch/mesh3D.py 44.57% 😞 45.57% 😞 1.00% 👍
gdsfactory/tests/test_read_gds_with_hierarchy.py 90.51% ⭐ 90.32% ⭐ -0.19% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/component.py Component.write_gds 15 🙂 310 ⛔ 16 ⛔ 29.84% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/gmsh/scratch/mesh3D.py mesh3D 12 🙂 240 ⛔ 16 ⛔ 35.30% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.remove_layers 22 😞 222 ⛔ 11 😞 35.70% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.ploth 8 ⭐ 443 ⛔ 12 😞 39.12% 😞 Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component.add_port 13 🙂 194 😞 14 😞 39.88% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab mentioned this pull request Oct 2, 2022
5 tasks
@joamatab
Copy link
Contributor Author

joamatab commented Oct 2, 2022

@thomasdorch

@joamatab joamatab merged commit 819a7c6 into master Oct 2, 2022
@joamatab joamatab deleted the 537 branch October 2, 2022 02:48
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant