Fix devsim #806

simbilod · 2022-11-01T04:45:50Z

DEVSIM can now be imported properly from scripts
Due to large requirements, there is now a requirements_file for DEVSIM, and it can be installed as
pip install gdsfactory[devsim]

sourcery-ai · 2022-11-01T04:46:11Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 0.31%.

Quality metrics	Before	After	Change
Complexity	2.17 ⭐	2.15 ⭐	-0.02 👍
Method Length	139.89 😞	141.47 😞	1.58 👎
Working memory	10.56 😞	10.67 😞	0.11 👎
Quality	59.34% 🙂	59.03% 🙂	-0.31% 👎

Other metrics	Before	After	Change
Lines	604	610	6

Changed files	Quality Before	Quality After	Quality Change
setup.py	48.54% 😞	46.13% 😞	-2.41% 👎
gdsfactory/simulation/devsim/get_simulation_xsection.py	60.21% 🙂	60.21% 🙂	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/simulation/devsim/get_simulation_xsection.py	PINWaveguide.make_waveguide	3 ⭐	286 ⛔	20 ⛔	38.43% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/devsim/get_simulation_xsection.py	PINWaveguide.create_2d_mesh	0 ⭐	634 ⛔	13 😞	44.66% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/devsim/get_simulation_xsection.py	PINWaveguide.set_net_doping	0 ⭐	188 😞	12 😞	55.72% 🙂	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/devsim/get_simulation_xsection.py	dn_carriers	3 ⭐	92 🙂	12 😞	63.50% 🙂	Extract out complex expressions
gdsfactory/simulation/devsim/get_simulation_xsection.py	PINWaveguide.plot	0 ⭐	99 🙂	11 😞	67.24% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

codecov · 2022-11-01T04:50:40Z

Codecov Report

Merging #806 (64756af) into master (bc1a255) will not change coverage.
The diff coverage is n/a.

❗ Current head 64756af differs from pull request most recent head 5006f02. Consider uploading reports for the commit 5006f02 to get more accurate results

@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   74.48%   74.48%           
=======================================
  Files         424      424           
  Lines       20980    20980           
  Branches     2837     2837           
=======================================
  Hits        15627    15627           
  Misses       4482     4482           
  Partials      871      871

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more