get_polygons is backwards compatible by default #846

joamatab · 2022-11-11T15:34:21Z

fixes #844

sourcery-ai · 2022-11-11T15:35:14Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 0.44%.

Quality metrics	Before	After	Change
Complexity	7.00 ⭐	7.30 ⭐	0.30 👎
Method Length	75.99 🙂	76.34 🙂	0.35 👎
Working memory	8.56 🙂	8.58 🙂	0.02 👎
Quality	64.47% 🙂	64.03% 🙂	-0.44% 👎

Other metrics	Before	After	Change
Lines	4535	4583	48

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/add_keepout.py	76.15% ⭐	75.89% ⭐	-0.26% 👎
gdsfactory/component.py	69.18% 🙂	68.25% 🙂	-0.93% 👎
gdsfactory/component_reference.py	71.62% 🙂	70.61% 🙂	-1.01% 👎
gdsfactory/fill.py	52.65% 🙂	52.64% 🙂	-0.01% 👎
gdsfactory/quickplotter.py	57.03% 🙂	57.00% 🙂	-0.03% 👎
gdsfactory/routing/get_route_astar.py	36.94% 😞	36.46% 😞	-0.48% 👎
gdsfactory/tests/test_shear_face_path.py	76.83% ⭐	77.49% ⭐	0.66% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/quickplotter.py	quickplot	51 ⛔	627 ⛔	20 ⛔	7.25% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/routing/get_route_astar.py	get_route_astar	37 ⛔	490 ⛔	19 ⛔	11.86% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py	Component.write_gds	15 🙂	327 ⛔	16 ⛔	29.36% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/fill.py	fill_rectangle	13 🙂	380 ⛔	15 😞	31.09% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component_reference.py	ComponentReference.move	15 🙂	280 ⛔	15 😞	31.99% 😞	Try splitting into smaller methods. Extract out complex expressions