Fix add port from labels #854

joamatab · 2022-11-12T18:28:53Z

fix import ports from siepic pins

sourcery-ai · 2022-11-12T18:29:09Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.34%.

Quality metrics	Before	After	Change
Complexity	25.20 😞	24.01 😞	-1.19 👍
Method Length	109.73 🙂	110.03 🙂	0.30 👎
Working memory	16.23 ⛔	15.85 ⛔	-0.38 👍
Quality	42.31% 😞	43.65% 😞	1.34% 👍

Other metrics	Before	After	Change
Lines	1005	1038	33

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/add_pins.py	61.50% 🙂	61.39% 🙂	-0.11% 👎
gdsfactory/add_ports.py	14.44% ⛔	14.41% ⛔	-0.03% 👎
gdsfactory/tests/test_add_ports.py	93.14% ⭐	85.55% ⭐	-7.59% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/add_ports.py	add_ports_from_markers_center	87 ⛔	562 ⛔	28 ⛔	1.82% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/add_ports.py	add_ports_from_labels	31 😞	248 ⛔	21 ⛔	18.17% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/add_ports.py	add_ports_from_siepic_pins	18 🙂	276 ⛔	17 ⛔	27.67% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/add_pins.py	add_pin_rectangle_double	1 ⭐	325 ⛔	18 ⛔	40.62% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/add_ports.py	add_ports_from_markers_square	8 ⭐	160 😞	18 ⛔	43.19% 😞	Try splitting into smaller methods. Extract out complex expressions