Fix and improve speed of flatten and absorb #875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @joamatab, this MR fixes handling of labels in
flatten()
andabsorb()
and improves speed dramatically.flatten()
now maintains labels (previously they were getting dropped)absorb()
now places labels in the correct location (previously they were not getting the reference's transformationsingle_layer
option inflatten()
now acceptsLayerSpec
, should behave properly, and has associated test