Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename reflect_h to mirror_x and reflect_v to mirror_y #896

Merged
merged 1 commit into from Nov 20, 2022
Merged

Conversation

joamatab
Copy link
Contributor

No description provided.

@joamatab joamatab merged commit d74b480 into master Nov 20, 2022
@joamatab joamatab deleted the 612b branch November 20, 2022 15:57
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 20, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 23.62 😞 23.62 😞 0.00
Method Length 81.45 🙂 81.45 🙂 0.00
Working memory 13.94 😞 13.94 😞 0.00
Quality 52.73% 🙂 52.73% 🙂 0.00%
Other metrics Before After Change
Lines 5194 5194 0
Changed files Quality Before Quality After Quality Change
gdsfactory/component.py 69.57% 🙂 69.57% 🙂 0.00%
gdsfactory/component_reference.py 71.55% 🙂 71.55% 🙂 0.00%
gdsfactory/components/component_sequence.py 43.97% 😞 43.97% 😞 0.00%
gdsfactory/read/from_yaml.py 22.66% ⛔ 22.66% ⛔ 0.00%
gdsfactory/routing/manhattan.py 30.18% 😞 30.18% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/routing/manhattan.py round_corners 80 ⛔ 1341 ⛔ 42 ⛔ 0.67% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/read/from_yaml.py _from_yaml 122 ⛔ 1074 ⛔ 28 ⛔ 1.24% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/read/from_yaml.py place 63 ⛔ 642 ⛔ 27 ⛔ 3.01% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/routing/manhattan.py _generate_route_manhattan_points 52 ⛔ 741 ⛔ 25 ⛔ 4.78% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/component.py Component._write_library 20 😞 356 ⛔ 18 ⛔ 23.01% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab mentioned this pull request Nov 20, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant