Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

difftest prompts you whether you want to do the xor diff #903

Merged
merged 1 commit into from Nov 21, 2022
Merged

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab merged commit 776878d into master Nov 21, 2022
@joamatab joamatab deleted the 621 branch November 21, 2022 16:06
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 21, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.77%.

Quality metrics Before After Change
Complexity 18.14 🙂 19.46 😞 1.32 👎
Method Length 177.25 😞 189.75 😞 12.50 👎
Working memory 13.89 😞 14.68 😞 0.79 👎
Quality 34.06% 😞 30.29% 😞 -3.77% 👎
Other metrics Before After Change
Lines 197 205 8
Changed files Quality Before Quality After Quality Change
gdsfactory/difftest.py 34.06% 😞 30.29% 😞 -3.77% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/difftest.py run_xor 25 😞 392 ⛔ 18 ⛔ 19.14% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/difftest.py difftest 15 🙂 298 ⛔ 12 😞 35.58% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab changed the title difftest prompts you wether you want to do the xor diff difftest prompts you whether you want to do the xor diff Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant