Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waveguide termination component #964

Merged
merged 5 commits into from Dec 7, 2022
Merged

Conversation

simbilod
Copy link
Collaborator

@simbilod simbilod commented Dec 7, 2022

Terminate dangling waveguides with heavily doped narrow taper to protect modulator, detectors, and other active electronics from stray light.

I guess this is identical to the taper components with a specific set of inputs, but it's commonly-used enough that it could get be its own component with good defaults, I will let the community decide

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #964 (c614935) into master (b9ba805) will decrease coverage by 0.27%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   74.36%   74.08%   -0.28%     
==========================================
  Files         431      433       +2     
  Lines       22032    22173     +141     
  Branches     2950     2972      +22     
==========================================
+ Hits        16383    16427      +44     
- Misses       4763     4857      +94     
- Partials      886      889       +3     
Impacted Files Coverage Δ
gdsfactory/components/taper_cross_section.py 100.00% <ø> (ø)
gdsfactory/components/terminator.py 56.25% <56.25%> (ø)
gdsfactory/read/from_yaml.py 67.26% <0.00%> (-1.05%) ⬇️
gdsfactory/pdk.py 51.92% <0.00%> (-0.09%) ⬇️
gdsfactory/geometry/check_space.py 84.21% <0.00%> (ø)
gdsfactory/symbols.py 34.00% <0.00%> (ø)
gdsfactory/schematic_editor.py 14.76% <0.00%> (+0.19%) ⬆️
gdsfactory/circuitviz.py 16.41% <0.00%> (+0.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 7, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.51%.

Quality metrics Before After Change
Complexity 1.00 ⭐ 1.00 ⭐ 0.00
Method Length 67.00 🙂 70.33 🙂 3.33 👎
Working memory 9.92 😞 9.46 🙂 -0.46 👍
Quality 73.00% 🙂 73.51% 🙂 0.51% 👍
Other metrics Before After Change
Lines 73 73 0
Changed files Quality Before Quality After Quality Change
gdsfactory/components/taper_cross_section.py 73.00% 🙂 73.51% 🙂 0.51% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/components/taper_cross_section.py taper_cross_section 1 ⭐ 102 🙂 15 😞 59.85% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit b8b3374 into gdsfactory:master Dec 7, 2022
@simbilod simbilod deleted the terminator branch December 18, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants