Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lots of files by using new pyproject.toml #977

Merged
merged 11 commits into from Dec 9, 2022
Merged

remove lots of files by using new pyproject.toml #977

merged 11 commits into from Dec 9, 2022

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Dec 9, 2022

remove lots of files by using new pyproject.toml

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 9, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 12.11%.

Quality metrics Before After Change
Complexity 0.20 ⭐ 0.33 ⭐ 0.13 👎
Method Length 84.29 🙂 46.67 ⭐ -37.62 👍
Working memory 10.85 😞 9.00 🙂 -1.85 👍
Quality 64.15% 🙂 76.26% 12.11% 👍
Other metrics Before After Change
Lines 148 39 -109
Changed files Quality Before Quality After Quality Change
fixme/pydantic_validator2_fix.py 76.26% ⭐ 76.26% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
fixme/pydantic_validator2_fix.py straight2a 0 ⭐ 91 🙂 12 😞 66.63% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #977 (700ca0c) into main (59e50d0) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   74.12%   74.03%   -0.09%     
==========================================
  Files         434      432       -2     
  Lines       22221    22194      -27     
  Branches     2980     2980              
==========================================
- Hits        16471    16432      -39     
- Misses       4862     4875      +13     
+ Partials      888      887       -1     
Impacted Files Coverage Δ
gdsfactory/read/from_phidl.py 36.66% <0.00%> (-40.00%) ⬇️
gdsfactory/tests/test_schema.py.disable

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 461d402 into main Dec 9, 2022
@joamatab joamatab deleted the pyproject branch December 9, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant