New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database #990
Conversation
Codecov Report
@@ Coverage Diff @@
## main #990 +/- ##
==========================================
+ Coverage 74.08% 74.34% +0.25%
==========================================
Files 433 434 +1
Lines 22217 22442 +225
Branches 2985 2985
==========================================
+ Hits 16459 16684 +225
Misses 4871 4871
Partials 887 887
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
would be great if we can generate a diagram of the database to review |
I can merge it and then we can add documentation on how to add data to it into future PRs: TODO:
Maybe:
|
hi @joamatab , overall it looks good to me. the only part I have any immediate criticisms for are the port type: you have also, do you have or see value in adding a relation to a PDK name/version used to make the wafer? or otherwise to the version of the code used to generate it? |
@tvt173
@flaport
@thomasdorch
@SkandanC
@proppy