Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database #990

Merged
merged 6 commits into from Dec 13, 2022
Merged

Database #990

merged 6 commits into from Dec 13, 2022

Conversation

joamatab
Copy link
Contributor

  • add database for structured data for simulations and measurements

@tvt173
@flaport
@thomasdorch
@SkandanC
@proppy

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #990 (a075b87) into main (e9552e8) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
+ Coverage   74.08%   74.34%   +0.25%     
==========================================
  Files         433      434       +1     
  Lines       22217    22442     +225     
  Branches     2985     2985              
==========================================
+ Hits        16459    16684     +225     
  Misses       4871     4871              
  Partials      887      887              
Impacted Files Coverage Δ
gdsfactory/database/models.py 100.00% <100.00%> (ø)
gdsfactory/components/terminator.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvt173
Copy link
Collaborator

tvt173 commented Dec 13, 2022

would be great if we can generate a diagram of the database to review
https://crashlaker.github.io/database/2020/05/13/database_diagram_with_python_sqlalchemy.html

@joamatab
Copy link
Contributor Author

joamatab commented Dec 13, 2022

Here is a diagram

image

@joamatab
Copy link
Contributor Author

I can merge it and then we can add documentation on how to add data to it into future PRs:

TODO:

  • add examples on how to add and query measurements and simulations
  • add examples on how to bring up and connect your own database

Maybe:

  • Include GDS serialization (polygons and references)
  • material database

@joamatab joamatab merged commit c5cc5c6 into main Dec 13, 2022
@joamatab joamatab deleted the database branch December 13, 2022 19:43
@joamatab joamatab mentioned this pull request Dec 13, 2022
7 tasks
@tvt173
Copy link
Collaborator

tvt173 commented Dec 14, 2022

hi @joamatab , overall it looks good to me. the only part I have any immediate criticisms for are the port type:
image

you have is_electrical and is_optical as columns, but I think it would be cleaner and more flexible to have something like port_type which is either a string or maps to a table of port types. what do you think?

also, do you have or see value in adding a relation to a PDK name/version used to make the wafer? or otherwise to the version of the code used to generate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants