Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for shapely 2.0 #996

Merged
merged 1 commit into from Dec 14, 2022
Merged

Conversation

HelgeGehring
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 14, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 56.48 ⛔ 56.48 ⛔ 0.00
Method Length 82.20 🙂 82.20 🙂 0.00
Working memory 11.26 😞 11.26 😞 0.00
Quality 44.93% 😞 44.93% 😞 0.00%
Other metrics Before After Change
Lines 219 219 0
Changed files Quality Before Quality After Quality Change
gdsfactory/simulation/gmsh/break_geometry.py 20.00% ⛔ 20.00% ⛔ 0.00%
gdsfactory/simulation/gmsh/parse_gds.py 72.64% 🙂 72.64% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gdsfactory/simulation/gmsh/break_geometry.py break_geometry 122 ⛔ 311 ⛔ 18 ⛔ 8.72% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
gdsfactory/simulation/gmsh/parse_gds.py tile_shapes 21 😞 115 🙂 9 🙂 50.47% 🙂 Refactor to reduce nesting

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #996 (3774d35) into main (4b7af4b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage   74.34%   74.34%           
=======================================
  Files         434      434           
  Lines       22441    22441           
  Branches     2985     2985           
=======================================
  Hits        16683    16683           
  Misses       4871     4871           
  Partials      887      887           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 72bbb05 into gdsfactory:main Dec 14, 2022
@HelgeGehring HelgeGehring deleted the fix_mesh_shapely2 branch December 14, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants