Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consitent layer stack name #157

Merged
merged 11 commits into from Sep 20, 2023
Merged

Consitent layer stack name #157

merged 11 commits into from Sep 20, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Sep 20, 2023 •
edited

  • update to latest tidy3d 2.4 and gdsfactory
  • rename layerstack to layer_stack to be consistent with gdsfactory
  • rename portnames to port_names to be consistent with python convention
  • fixes coverage issue #153

@simbilod
@yaugenst
@nikosavola

@simbilod
Copy link
Collaborator

Thanks!

@joamatab joamatab mentioned this pull request Sep 20, 2023
Closed
@joamatab joamatab merged commit 2031f94 into main Sep 20, 2023
12 checks passed
@joamatab joamatab deleted the consitent_layer_stack_name branch September 20, 2023 17:54
@nikosavola nikosavola mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coverage issue
2 participants
@joamatab @simbilod