Fix mzi notebook and batch #255
Conversation
for more information, see https://pre-commit.ci
|
@joamatab note that after flexcompute/tidy3d#1259 is released officially, I think (?) you won't need to do the hash workaround. but glad you found a way around it for now. |
|
Sounds good Tyler, let me know when make a pre-release so that we can start using it |
|
2.5.0rc3 was just released a few minutes ago! so you can try that out |
| @@ -498,6 +499,7 @@ def write_sparameters( | |||
| pad_z_outer=pad_z_outer, | |||
| dilation=dilation, | |||
| ) | |||
| path_dir = str(pathlib.Path(dirpath) / str(hash(c))) | |||
There was a problem hiding this comment.
This will hash to different values on different runs I believe? If we use the fix from flexcompute/tidy3d#1259 then we should call c._hash_self() here instead.
There was a problem hiding this comment.
it has the same value on different runs
There was a problem hiding this comment.
are you sure? across different interpreter instances?
There was a problem hiding this comment.
the hash is coming from Tidy3D component modeller
i run with different interpreter instances and was working well
There was a problem hiding this comment.
@joamatab the problem is that hash() gets a new random seed with different interpreter instances. which is why we had to implement the _hash_self(). I'm actually surprised it gave the same results for you, I wouldn't have expected that. Might want to double check just to save yourself some headache later.
There was a problem hiding this comment.
Hi Tyler, yes, but Tidy3DComponent is not your modeler but a new object that inherits from the LayeredComponentBase that Yannick wrote
class Tidy3DComponent(LayeredComponentBase):
"""
Represents a 3D component in the Tidy3D simulation environment.
Attributes:
material_mapping (dict[str, Tidy3DMedium]): A mapping of material names to Tidy3DMedium instances.
extend_ports (NonNegativeFloat): The extension length for ports.
port_offset (float): The offset for ports.
pad_xy_inner (NonNegativeFloat): The inner padding in the xy-plane.
pad_xy_outer (NonNegativeFloat): The outer padding in the xy-plane.
pad_z_inner (float): The inner padding in the z-direction.
pad_z_outer (NonNegativeFloat): The outer padding in the z-direction.
dilation (float): Dilation of the polygon in the base by shifting each edge along its
normal outwards direction by a distance;
a negative value corresponds to erosion. Defaults to zero.
"""
material_mapping: dict[str, Tidy3DMedium] = material_name_to_medium
extend_ports: NonNegativeFloat = 0.5
port_offset: float = 0.2
pad_xy_inner: NonNegativeFloat = 2.0
pad_xy_outer: NonNegativeFloat = 2.0
pad_z_inner: float = 0.0
pad_z_outer: NonNegativeFloat = 0.0
dilation: float = 0.0
fixes flexcompute/tidy3d#1276
@yaugenst
@tylerflex