small doc fixes #380
Merged
small doc fixes #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @joamatab - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| if rdb_path.is_dir(): | ||
| for rdb_file in rdb_path.glob("*.rdb"): | ||
| errors_dict[rdb_file.stem] = count_drc(rdb_file) | ||
| if not rdb_path.is_dir(): |
There was a problem hiding this comment.
suggestion (code_refinement): Consider simplifying the conditional structure for readability.
The nested conditionals could be streamlined by handling the directory check and file processing in separate functions or by restructuring the logic.
Suggested change
| if not rdb_path.is_dir(): | |
| def handle_directory_check(rdb_path): | |
| if not rdb_path.is_dir(): | |
| return _get_errors(rdb_path, threshold, errors_dict) | |
| return None | |
| # Usage in your existing code | |
| error_check = handle_directory_check(rdb_path) | |
| if error_check is not None: | |
| return error_check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.