Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-Angle Bundle Router #247

Closed
sebastian-goeldi opened this issue Feb 10, 2024 · 4 comments
Closed

All-Angle Bundle Router #247

sebastian-goeldi opened this issue Feb 10, 2024 · 4 comments
Assignees

Comments

@sebastian-goeldi
Copy link
Collaborator

For the gdsfactory migration to kfactory backend, we need an all-angle bundle router. I assume this will be similar to the single all-angle router based on a backbone provided.

Is that right @tvt173 ?

@sebastian-goeldi sebastian-goeldi self-assigned this Feb 10, 2024
@joamatab
Copy link
Collaborator

yes, that's correct

@tvt173
Copy link
Collaborator

tvt173 commented Feb 13, 2024

to be picky, it would be great if the API doesn't change from the existing all-angle bundle router in gdsfactory. there's quite a bit of functionality packed into it, such as custom connectors, bends, cross-sections, etc.

@sebastian-goeldi sebastian-goeldi changed the title All-Angle Bunlde Router All-Angle Bundle Router Mar 1, 2024
@sebastian-goeldi
Copy link
Collaborator Author

sebastian-goeldi commented Mar 1, 2024

I think I will not get around to not at the very least drop some args/kwargs. There are no cross-sections, But I could offer KCellEnclosure which would be cross-section on steroids as it can do it for multiple center pieces. But for starters, I would like to avoid that.

Also, there's a decision to make wrt how it looks like. I think for the low-level interface such as kfactory it doesn't make much sense to do stuff like resolution of factories by name. I mean we can, but then we would be forcing people's hands to create a pdk.

Also, there isn't really such a thing as passing references in kfactory. I could hack it for the virtual cells, but then the function footprints for virtual / all-angle would deviate significantly from manhattan routing.

@sebastian-goeldi
Copy link
Collaborator Author

Added by #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants