Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VKCell/VInstance #305

Merged
merged 7 commits into from
May 7, 2024
Merged

Conversation

sebastian-goeldi
Copy link
Collaborator

@sebastian-goeldi sebastian-goeldi commented Apr 28, 2024

Fixes #283

  • Adds convenience from KCell/Instance to VKCell/VInstance
  • Add other: KCell|VKCell >> c KCell|VKCell
  • All angle bundle router
  • On write (KCell/KCLayout) call foreach kcell in kcl.kcells; do kcell.insert_vinsts()

@github-actions github-actions bot added the enhancement New feature or request label Apr 28, 2024
@sebastian-goeldi sebastian-goeldi marked this pull request as ready for review May 7, 2024 20:40
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sebastian-goeldi - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 2 issues found
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/kfactory/kcell.py Show resolved Hide resolved
src/kfactory/routing/aa/optical.py Show resolved Hide resolved
src/kfactory/routing/aa/optical.py Show resolved Hide resolved
src/kfactory/routing/aa/optical.py Show resolved Hide resolved
src/kfactory/kcell.py Show resolved Hide resolved
src/kfactory/routing/aa/optical.py Show resolved Hide resolved
src/kfactory/routing/aa/optical.py Show resolved Hide resolved
src/kfactory/routing/aa/optical.py Show resolved Hide resolved
src/kfactory/routing/aa/optical.py Show resolved Hide resolved
src/kfactory/routing/aa/optical.py Show resolved Hide resolved
@sebastian-goeldi sebastian-goeldi merged commit b1458e5 into main May 7, 2024
7 checks passed
@sebastian-goeldi sebastian-goeldi deleted the add-vkcell-convenience-functions branch May 7, 2024 21:07
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support KCell.min, KCell.min , Instance.xmin, INstance.ymin ... in um
2 participants