Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interconnect plugin #14

Merged
merged 6 commits into from Mar 16, 2022
Merged

Interconnect plugin #14

merged 6 commits into from Mar 16, 2022

Conversation

thomasdorch
Copy link
Contributor

No description provided.

@thomasdorch
Copy link
Contributor Author

The coupler doesn't work with the latest Interconnect plugin changes.
The Interconnect model tries to call FDTD because it doesn't have Sparameters that match the component specifications. Not sure how to fix the FDTD link, or whether it's better to pass our own Sparameters instead somehow..

@joamatab joamatab merged commit d9a5bf0 into gdsfactory:master Mar 16, 2022
@joamatab joamatab mentioned this pull request Mar 16, 2022
Merged
@thomasdorch thomasdorch deleted the interconnect_plugin branch April 25, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasdorch @joamatab