Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

163 #49

Merged
merged 2 commits into from Jun 15, 2022
Merged

163 #49

merged 2 commits into from Jun 15, 2022

Conversation

joamatab
Copy link
Contributor

update to gdsfactory[full]==5.10.1

@joamatab joamatab merged commit 248afbc into master Jun 15, 2022
@joamatab joamatab deleted the 163 branch June 15, 2022 03:26
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 15, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.42%.

Quality metrics Before After Change
Complexity 0.30 ⭐ 0.40 ⭐ 0.10 👎
Method Length 59.68 ⭐ 51.94 ⭐ -7.74 👍
Working memory 8.17 🙂 8.24 🙂 0.07 👎
Quality 73.54% 🙂 74.96% 🙂 1.42% 👍
Other metrics Before After Change
Lines 466 299 -167
Changed files Quality Before Quality After Quality Change
ubcpdk/init.py 61.50% 🙂 58.15% 🙂 -3.35% 👎
ubcpdk/tech.py 63.10% 🙂 63.72% 🙂 0.62% 👍
ubcpdk/simulation/circuits_simphony.py 95.41% ⭐ 95.41% ⭐ 0.00%
ubcpdk/tests/test_simulation_circuits.py 74.95% 🙂 78.69% ⭐ 3.74% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ubcpdk/tests/test_simulation_circuits.py test_elements 0 ⭐ 93 🙂 13 😞 64.78% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant