Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest gdsfactory #57

Merged
merged 1 commit into from Jul 3, 2022
Merged

update to latest gdsfactory #57

merged 1 commit into from Jul 3, 2022

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jul 3, 2022

update to gdsfactory[full]==5.12.9

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 3, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 4.39%.

Quality metrics Before After Change
Complexity 0.24 ⭐ 0.27 ⭐ 0.03 👎
Method Length 111.60 🙂 121.00 😞 9.40 👎
Working memory 6.38 🙂 7.28 🙂 0.90 👎
Quality 74.12% 🙂 69.73% 🙂 -4.39% 👎
Other metrics Before After Change
Lines 248 233 -15
Changed files Quality Before Quality After Quality Change
docs/conf.py 87.48% ⭐ 76.57% ⭐ -10.91% 👎
ubcpdk/tech.py 63.84% 🙂 65.39% 🙂 1.55% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #57 (aa9f9aa) into master (d79ad92) will decrease coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   61.30%   61.00%   -0.31%     
==========================================
  Files          24       24              
  Lines         504      500       -4     
==========================================
- Hits          309      305       -4     
  Misses        195      195              
Impacted Files Coverage Δ
ubcpdk/components/cells.py 62.16% <ø> (-1.00%) ⬇️
ubcpdk/components/grating_couplers.py 64.70% <ø> (ø)
ubcpdk/tech.py 96.00% <ø> (-0.30%) ⬇️
ubcpdk/__init__.py 90.90% <100.00%> (ø)
ubcpdk/config.py 98.07% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a92ede...aa9f9aa. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joamatab joamatab merged commit 93ca9e8 into master Jul 3, 2022
@joamatab joamatab deleted the 165 branch July 3, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant