Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for 1.4.x jQuery.easing.method() is needed #25

Open
starlocke opened this issue Mar 27, 2017 · 14 comments
Open

Documentation for 1.4.x jQuery.easing.method() is needed #25

starlocke opened this issue Mar 27, 2017 · 14 comments

Comments

@starlocke
Copy link

starlocke commented Mar 27, 2017

The documentation for the plugin at the official site http://gsgd.co.uk/sandbox/jquery/easing/ needs to be updated to explain and guide other developers around the breaking of the Bonus feature where easing 1.3.x is based on jQuery 1.x and 2.x and easing 1.4.x is based on jQuery 3.x.

It would be nice to also have this documentation in the README.md for https://github.com/gdsmith/jquery.easing

jQuery.easing.method()'s old signature no longer works the same in 1.4.x:

jQuery.easing.method(
	null†,
	current_time,
	start_value,
	end_value,
	total_time)

Wherever it is used directly in custom animations, the formula needs to be tweaked into this form:

// - x is (current_time / total_time), aka "percentage completed"
// - d is (end_value - start_value), aka "distance"
// - s is (start_value), if not zero
jQuery.easing.method(x) * d + s

One example of using jQuery.easing.method() directly is when creating window.scrollBy() smooth scroll animations. jQuery handles CSS animations easily, but doesn't quite fit for controlling window scrolling position, as far as I know.

@batata004
Copy link

That's a shame that the dev of this library does not even care about users of it. This is an important thread and clearly nobody cared to take it into consideration. I think we are better using other easing alternatives like the ones provided by semantic ui. The best alternative is to stay away from this library cause clearly they dont care about documentation and dont care about bugs.

@dmethvin
Copy link
Contributor

@batata004 Have you made a pull request? Anyone can do one. Since this is open source, you are as responsible as anyone.

@batata004
Copy link

batata004 commented Aug 22, 2017

No, I am not "responsible as anyone", you are wrong my friend.

If I created a library, shared it with the community and allowed people/business to use it in millions of websites I WOULD AT LEAST CARE a little bit with bugs since I was the one that started this and encouraged others to use it.

I am not responsable for people who publish libraries, share them, allow so many other people to use them and after that care shi*t about it so if a bug is discovered this person will not take care of it.

Looks like nobody is gonna fix this bug, so I will move on and use other library.

@dmethvin
Copy link
Contributor

Looks like nobody is gonna fix this bug

In open source, fixing the bug that affects you is called "scratching the itch". Clearly this bug itches you but you want someone else to scratch it. For free. On your schedule. Based on your need. Because you think it's a priority. That's not the way open source works.

I do hope that you too create a successful library and share it with the community so that it is used by millions of web sites for many years. Then you will have some empathy for the people who provide their time to build the free software that you use.

@batata004
Copy link

I didnt ask you to scratch my itch, I did ask you to provide a fix to the community. You will not be scratching my itch, I already removed the itch ditching this terrible library and moving to a better one that makes use of semantic ui; which is a win-win. I couldnt be happier that you treated my like shi*t,cause this way I could research a little bit more about this subject and found a much better and well integrated easing plugin embed in semantic ui.

I dont need you to scratch my itch, maybe now you will have to scratch other's people itch cause mine is solved, I did what a smart people do: if who provide a service does not honor the basics of a good service (even if it's a free service), ditch that service and move to another one!

I am glad you were a d*ck and treated me like and idiot. I took some time to come here and give you a heads up of this bug but you didnt care. What else can I say about you?

@dmethvin
Copy link
Contributor

Looking at your original post above, agree that you didn't ask for anything. I'm not sure what you mean by "heads up on this bug", your comment didn't clarify what was here. Instead, it "shamed" the contributors for not having solved the problem when you needed it solved.

You've decided to use something else because continuing to use this project would require you to contribute to fix it, that's fine and I have done the same myself. However, that makes it even more unacceptable to come here and post insults. Just silently move on to something else if you don't have the time or expertise to fix this.

@batata004
Copy link

"I dont have time or expertise to fix this" - yeap.

@gdsmith
Copy link
Owner

gdsmith commented Aug 24, 2017

@batata004 I think there's some confusion in this thread, the original request is for an update to the docs, this isn't really a bug, and the fact it's here lets people get what they need while I'm not able to find time to update the documentation.

Also, dmethvin is not the creator of the plugin (I am), but basically rewrote the plugin for jQuery 3. If you are referring rather, to your own separate issue, then please can you keep the comments there?

I also don't think anyone was being a dick, just gently hinting to you that this is something you get for free, and you can, if you so wish, help to fix things when they're not working quite how you need them to.

@starlocke
Copy link
Author

starlocke commented Aug 24, 2017

I noticed that I mistakenly linked towards the GitHub site twice in the original post. I've now edited it to show original site first, followed by GitHub. The edit gets the comment about "README.md" to make sense again.

@batata004
Copy link

@gdsmith sorry, I will not post here anymore, I will follow up in the thread that I opened.

@BenUniqcode
Copy link

I just got bitten by the fact that the website - which is the top hit on google for "jquery easing plugin", while this repo is only 3rd - is out of date. I was trying to use v1.3 from the website and wondering why none of the easing functions worked. Never mind the docs, just a quick update to the website to say that it's out of date and point people here instead, would save thousands of people from the wasted time I've just had.

@gdsmith
Copy link
Owner

gdsmith commented Mar 4, 2021

@BenUniqcode thanks for the bump, I've done as you suggested, do you think that's obvious enough?

@BenUniqcode
Copy link

@gdsmith I reckon that'll do it :D Thanks for the prompt response!

@bipul57
Copy link

bipul57 commented Jun 14, 2021

Thanks for the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants