Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https site through a proxy #8

Open
awsmhacks opened this issue Oct 5, 2016 · 1 comment
Open

https site through a proxy #8

awsmhacks opened this issue Oct 5, 2016 · 1 comment

Comments

@awsmhacks
Copy link

awsmhacks commented Oct 5, 2016

1st issue
I believe the lines:
if options.proxy:
handlers.append( urllib2.ProxyHandler( {'http':'http://'+options.proxy}) )

fail to work if the site is https. changing the above to
if options.proxy:
handlers.append( urllib2.ProxyHandler( {'https':'https://'+options.proxy}) )

i was able to make the request work through burp. I'm guessing if urllib2 is using an https handler it will ignore a proxyhanlder set using http.

2nd issue=
The help instructs to use "http://proxy.com" while the if statement is only expecting a domain:port.

Both issues could be fixed by changing the if options.proxy section to:

if options.proxy:
if url.startswith( "https://" ):
handlers.append( urllib2.ProxyHandler( {'https':'https://'+options.proxy}) )
if url.startswith( "http://" ):
handlers.append( urllib2.ProxyHandler( {'http':'http://'+options.proxy}) )

and changing the help for proxy example to -p "site.com:8080"

@nopslider
Copy link

+1 was just about to open this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants