Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subtypes of wasGeneratedBy #541

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Remove subtypes of wasGeneratedBy #541

merged 2 commits into from
Nov 29, 2021

Conversation

glguy
Copy link
Contributor

@glguy glguy commented Aug 18, 2021

These subtypes are not offering a semantic refinement and are being used as aliases for the underlying wasGeneratedBy relationship that should be used in place of these aliases.

@glguy glguy self-assigned this Aug 18, 2021
@glguy glguy marked this pull request as draft August 18, 2021 21:17
@glguy glguy added the ontology Improvements or additions to the underlying ontology label Aug 18, 2021
@kityansiu kityansiu added this to the Pre-Release 9 milestone Nov 2, 2021
@kityansiu kityansiu added this to To Do in Pre-Release 9 via automation Nov 2, 2021
@kityansiu
Copy link
Contributor

I added this PR to Pre-Release 9 so we don't lose track of it if we want to get it into the next release.

@glguy glguy force-pushed the simplify-wasGeneratedBy branch 2 times, most recently from aa6779c to e02c74f Compare November 2, 2021 20:15
@glguy glguy marked this pull request as ready for review November 2, 2021 20:15
@glguy glguy moved this from To Do to In Progress in Pre-Release 9 Nov 5, 2021
@glguy
Copy link
Contributor Author

glguy commented Nov 6, 2021

GramaTech uses http://arcos.rack/TESTING#producedBy, SRI uses http://arcos.rack/SYSTEM#producedBy

I think this change is worth doing, but we'll want these teams to update their ingestion process not to use the subrelations.

@glguy glguy merged commit 27fa0d8 into master Nov 29, 2021
Pre-Release 9 automation moved this from In Progress to Done Nov 29, 2021
@glguy glguy deleted the simplify-wasGeneratedBy branch November 29, 2021 19:49
@kityansiu
Copy link
Contributor

@cuddihyge, can you please regenerate the nodegroups to reflect these changes? At minimum, ingestion/arcos.rack and probably ingestion/arcos.turnstile.

@cuddihyge
Copy link
Contributor

@tuxji John, are these being generated automatically during the CI yet, or should we still build them manually and check them in.
(this is the IngestTemplateGenerator step that builds CDR's)

@tuxji
Copy link
Contributor

tuxji commented Nov 30, 2021

Not yet. I will start making the changes needed to generate the nodegroups automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ontology Improvements or additions to the underlying ontology
Projects
No open projects
Pre-Release 9
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants