Add RTX overlay to support synthetic analysis outputs #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kityansiu
requested changes
Apr 7, 2022
There was a problem hiding this comment.
Just 2 recommendations:
- in the sadl file, we've been using the convention uri "http://arcos.projectName/companyName" alias projectName. Can we change line 13 in RTX.sadl to
uri "http://arcos.aace/RTX" alias aace? - the directory in nodegroups/ingestion will then become arcos.aace. Can we change line 29 in setup-arcos.sh to
rack nodegroup import ../nodegroups/ingestion/arcos.aace?
Other than these, I think the changes look good!
|
I think we missed updating setup-owl.sh to copy RACK/RTX-Ontology/OwlModels! |
|
@kityansiu now fixed on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.