Copy-to-default-graph-generalization #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisenje
reviewed
Feb 21, 2023
weisenje
reviewed
Feb 21, 2023
glguy
force-pushed
the
copy-to-default-graph-generalization
branch
from
d474331
to
e888b01
Compare
Ptival
approved these changes
Feb 21, 2023
| @@ -501,7 +500,7 @@ def build_manifest_driver( | |||
| zipfile_path: Path | |||
| ) -> None: | |||
|
|
|||
| with tempfile.TemporaryDirectory() as outdir: | |||
| with TemporaryDirectory() as outdir: | |||
There was a problem hiding this comment.
Is it the case that builder.model_graphs and builder.data_graphs depend on having created the archive?
At face value it looks like it's never explicitly used, but I assume there's a reason why it needs to be created, even if temporarily.
There was a problem hiding this comment.
I'm currently only collecting those graph names as debugging output. I am imagining that we could extend that in the future to report and error if the URLs were missing from the manifest's footprint:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #912